Skip to content

Implement PCZT support #1270

Implement PCZT support

Implement PCZT support #1270

Triggered via pull request December 3, 2024 11:48
@str4dstr4d
synchronize #440
pczt
Status Failure
Total duration 1m 12s
Artifacts

lints-stable.yml

on: pull_request
Clippy (MSRV)
1m 3s
Clippy (MSRV)
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 1 warning
using `clone` on type `note::RandomSeed` which implements the `Copy` trait: src/lib.rs#L298
error: using `clone` on type `note::RandomSeed` which implements the `Copy` trait --> src/builder.rs:298:25 | 298 | rseed: Some(self.note.rseed().clone()), | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.note.rseed()` | = note: `-D clippy::clone-on-copy` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `note::RandomSeed` which implements the `Copy` trait: src/lib.rs#L388
error: using `clone` on type `note::RandomSeed` which implements the `Copy` trait --> src/builder.rs:388:25 | 388 | rseed: Some(note.rseed().clone()), | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*note.rseed()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
this function has too many arguments (13/7): src/lib.rs#L97
error: this function has too many arguments (13/7) --> src/pczt/parse.rs:97:5 | 97 | / pub fn parse( 98 | | nullifier: [u8; 32], 99 | | rk: [u8; 32], 100 | | spend_auth_sig: Option<[u8; 64]>, ... | 110 | | proprietary: BTreeMap<String, Vec<u8>>, 111 | | ) -> Result<Self, ParseError> { | |_________________________________^ | = note: `-D clippy::too-many-arguments` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (11/7): src/lib.rs#L205
error: this function has too many arguments (11/7) --> src/pczt/parse.rs:205:5 | 205 | / pub fn parse( 206 | | spend_nullifier: Nullifier, 207 | | cmx: [u8; 32], 208 | | ephemeral_key: [u8; 32], ... | 216 | | proprietary: BTreeMap<String, Vec<u8>>, 217 | | ) -> Result<Self, ParseError> { | |_________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
question mark operator is useless here: src/lib.rs#L33
error: question mark operator is useless here --> src/pczt/tx_extractor.rs:33:17 | 33 | / Ok(action 34 | | .spend 35 | | .spend_auth_sig 36 | | .clone() 37 | | .ok_or(TxExtractorError::MissingSpendAuthSig)?) | |___________________________________________________________________^ | = note: `-D clippy::needless-question-mark` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 33 ~ action 34 + .spend 35 + .spend_auth_sig 36 + .clone() 37 + .ok_or(TxExtractorError::MissingSpendAuthSig) |
this expression creates a reference which is immediately dereferenced by the compiler: src/lib.rs#L90
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/pczt/tx_extractor.rs:90:45 | 90 | let authorization = bundle_auth(&self)?; | ^^^^^ help: change this to: `self` | = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
you are deriving `PartialEq` and can implement `Eq`: src/lib.rs#L273
error: you are deriving `PartialEq` and can implement `Eq` --> src/pczt.rs:273:26 | 273 | #[derive(Debug, Getters, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = note: `-D clippy::derive-partial-eq-without-eq` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
aborting due to 7 previous errors
error: aborting due to 7 previous errors
Clippy (MSRV)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636