Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return correct gRPC error codes #503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LarryRuane
Copy link
Collaborator

closes #497

@LarryRuane LarryRuane requested a review from nuttycom October 30, 2024 22:30
@LarryRuane LarryRuane self-assigned this Oct 30, 2024
@LarryRuane LarryRuane force-pushed the 2024-10-error-codes-497 branch from 4cacf9e to 7236235 Compare November 2, 2024 18:11
@LarryRuane
Copy link
Collaborator Author

This PR includes some whitespace changes to common/common_test.go because my IDE (vscode) automatically formats files, and an earlier commit to this file used a different formatting convention. I recommend viewing the diff with whitespace ignored (click on the gear symbol near the top of the Files changed (diff) page).

@LarryRuane LarryRuane force-pushed the 2024-10-error-codes-497 branch from 7236235 to 0c25590 Compare November 6, 2024 22:38
@LarryRuane LarryRuane force-pushed the 2024-10-error-codes-497 branch from 0c25590 to fc4548b Compare December 1, 2024 22:19
@LarryRuane LarryRuane force-pushed the 2024-10-error-codes-497 branch from fc4548b to 8662df7 Compare December 11, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zcash rpc error codes are not being correctly mapped to GRPC responses.
3 participants