add --nocache option to disable compact block file cache #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya2
reviewed
Jun 10, 2024
LarryRuane
force-pushed
the
2024-05-nocache
branch
from
fa286fc to
668cd0f
Compare
|
Force pushed review suggestion, thanks @arya2. Perhaps you can review again and approve? I think this is ready to be merged. |
arya2
approved these changes
Jun 13, 2024
This fixes issue zcash#480. Enabling this option decreases the performance of gRPCs GetBlock and GetBlockRange, but conserves disk space (the size of the database is currently around 17GB). Note, specifying this option will also delete the existing cache (so if you start again without --nocache, the cache will need to be recreated).
LarryRuane
force-pushed
the
2024-05-nocache
branch
from
668cd0f to
e0503c4
Compare
|
Force pushed to rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #480. Enabling this option decreases the performance of gRPCs GetBlock and GetBlockRange, but conserves disk space (the current database size is about 17GB).
Note, specifying this option will also delete the existing cache (so if you start again without --nocache, the cache will need to be recreated).