-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gRPC over websocket to allow direct access from browsers #450
Comments
I asked chatGPT about this -- did I ask the question correctly? https://chat.openai.com/share/02a1ba5b-217f-42a4-986d-d191f70866c3 It seems to suggest supporting websocket but maybe not http/1.1. Is that acceptable? (I really don't understand this area very well.) |
Can you provide some motivation for this? I would have to justify spending time on this (if possible), thanks. |
That would be ideal, I'm not sure if http/1.1 would support the streams, and websockets offer more flexibility / lower latency. |
Hey @LarryRuane how is this going? |
I'm just getting around to this finally, sorry for the delay, I'll try to get this done within the next week or so. |
@LarryRuane There may also be interest in calling these RPCs from a serverless environment where websockets don't work well, so adding regular http/1.1 REST endpoints would be valuable too. |
ChatGPT prioritises giving confident answers over correct answers, so I'd encourage you to check those answers with StackOverflow or the Go library reference, and test that all the RPCs work. Here's some background on ChatGPT's lack of reliability - a study found that ChatGPT got code questions wrong 52% of the time: |
Is this still being worked on? @LarryRuane |
Motivation
Using lightwalletd from the browser currently requires a proxy server to provide an http/1.1 transport. or gRPC over websocket.
Integrating gRPC over websocket support will offer web developers the direct access to lightwalletd that native developers currently enjoy.
The text was updated successfully, but these errors were encountered: