shardtree: Significantly rework handling of checkpoint depths and truncation operations. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
shardtree_rewind_to
branch
2 times, most recently
from
5583ba8 to
8189418
Compare
daira
reviewed
Sep 26, 2024
| } | ||
|
|
||
| fn rewind(&mut self, depth: usize) -> bool { | ||
| if self.checkpoints.len() > depth { |
There was a problem hiding this comment.
Shouldn't it be valid to rewind by exactly the number of checkpoints?
There was a problem hiding this comment.
Depth is treated as a (reverse-ordered) 0-based index, so it must be less than the length.
str4d
requested changes
Sep 27, 2024
The previous semantics of the `rewind` operation would remove the last checkpoint, if any, but would not further modify the tree. However, these semantics are error prone - if you rewind to a checkpoint, you are not able to rewind to the same checkpoint again; also, in practice, it doesn't make sense to shift the location of a checkpoint in the note commitment tree. This change alters `rewind` to (a) take an explicit checkpoint depth, with depth `0` meaning that any state added since the last checkpoint should be discarded, and (b) only allow a rewind operation to succeed if a checkpoint actually exists at the specified depth.
nuttycom
force-pushed
the
shardtree_rewind_to
branch
from
8189418 to
9a77e51
Compare
|
force-pushed to address comments from code review. |
nuttycom
commented
Sep 27, 2024
Co-authored-by: Jack Grigg <[email protected]>
nuttycom
force-pushed
the
shardtree_rewind_to
branch
from
a8c17ce to
3f59900
Compare
str4d
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.