-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit uses of .unwrap
/.expect
in shardtree
#118
Comments
This (along with one unwrap in
This should be justifiable because of the invariant that you cannot construct a witness for an empty tree. However,
These are all justifiable.
All except two of these (excluding the one mentioned above) are justifiable. The other two are technically justifiable in the context they get used, but their public APIs don't enforce the necessary invariant, so should be fixed (with the |
A witness cannot exist for an empty tree. Part of #118.
Opened #120. (Due to @nuttycom changing how we do crate development in #116, we can't change |
A witness cannot exist for an empty tree. Part of #118.
At least the unwraps for DB access seem like a bug to me.The text was updated successfully, but these errors were encountered: