Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with table representation inside terminal. #157

Open
ThisIsTeddyBear opened this issue Jul 26, 2023 · 13 comments
Open

Issue with table representation inside terminal. #157

ThisIsTeddyBear opened this issue Jul 26, 2023 · 13 comments
Labels
bug Something isn't working help wanted Extra attention is needed semver:patch
Milestone

Comments

@ThisIsTeddyBear
Copy link

Whenever there is no space left in the terminal for a new table it just cramps everything inside the left over space in terminal previously it was not like this and it automatically used to scroll and made new space in the latest guthub repository chages there has been some issues with the terminal and the load time of the table.
Screenshot 2023-07-26 144630

As you can see the issue that im talking about please try to fix it as soon as possible or LMK what changes are reqired to be made Ill make sure to fix them and use it.

@ThisIsTeddyBear
Copy link
Author

The table which is not being shown is another game and the table was loaded but was not shown in terminal as there was no space left, previous versions of yoinker did not have these issues it something wrong in the newer builds after using RichTable.
Pretty table are a better alternative that was used before I hope you can understand the issue and fix it soon.

@ThisIsTeddyBear
Copy link
Author

From my testing the feature PREVIOUS_RANK is causing this issue and leave that alone RICH Table is already very buggy, so I would suggest use some other alternative table representation and also fix the bug in PREVIOUS_RANK which is causing this issue.

@ThisIsTeddyBear
Copy link
Author

One more importing thing to note is that this issue of table deformation and being limited in the screen only when running the VALORANT-Yoinker with python main.py
After building the application using pip install cx_Freeze and python setup.py build and running the VRY.exe there is no issue in the terminal so Im unaware what is the exact reason causing the issue with tables. Look into this as well once

@ThisIsTeddyBear
Copy link
Author

@OwOHamper @zayKenyon Can you update on this issue.

@zayKenyon zayKenyon added this to the 2.6 milestone Jul 31, 2023
@zayKenyon
Copy link
Owner

I think I've fixed it, feel free to re-open if wrong.

@ThisIsTeddyBear
Copy link
Author

Yup with these changes the issue has been fixed. Hey I would like to know that in anyway can I contribute in this repository ? If there is I would love to make some contributions.

@zayKenyon
Copy link
Owner

Glad to hear it's worked. Thanks for wanting to get involved! A good place to start would be any issues currently tagged with the "help wanted" flair.

@ThisIsTeddyBear
Copy link
Author

@zayKenyon Sure would see if there is anything that I can help with, One small issue in the table representation is that now the new tables load properly, but the new tables disrupt the old ones but they are created properly no issue in that.

@zayKenyon
Copy link
Owner

Oh crap, what do you mean by disrupt?

@ThisIsTeddyBear
Copy link
Author

ThisIsTeddyBear commented Aug 1, 2023

Meaning the new table is created properly but the old table is space which was there it sometimes takes that space and overwrites on top of the old table.

It is weird to explain but this happens a lot of time. Will add a screenshot and explain it properly once I test and play some games later this evening.

@ThisIsTeddyBear
Copy link
Author

ThisIsTeddyBear commented Aug 1, 2023

@zayKenyon As you can see in this image the new tables are propely formed, but now the issue is with this

Screenshot 2023-08-01 181600

Same error goes with the .exe application when it is bundled, not sure what is causing this issue. Hope this issue is reopened and fixed.
Hope you would be able to fix this, just a minor issue.

@zayKenyon zayKenyon reopened this Aug 1, 2023
@zayKenyon zayKenyon added bug Something isn't working help wanted Extra attention is needed semver:patch labels Aug 1, 2023
@zayKenyon zayKenyon modified the milestones: 2.6, 2.7 Sep 17, 2023
@D3CRYPT360
Copy link
Contributor

Hi am currently working on fixing this, is there anyway i can reach you on discord @ThisIsTeddyBear

@ThisIsTeddyBear
Copy link
Author

Hi am currently working on fixing this, is there anyway i can reach you on discord @ThisIsTeddyBear

Here is my discord ID- akuljain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed semver:patch
Projects
None yet
Development

No branches or pull requests

3 participants