Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color helpers should have !important tag #6

Open
diosney opened this issue Jul 22, 2015 · 2 comments
Open

Color helpers should have !important tag #6

diosney opened this issue Jul 22, 2015 · 2 comments

Comments

@diosney
Copy link

diosney commented Jul 22, 2015

So they can override custom default colors by themselves.

@zavoloklom
Copy link
Owner

I don't like to add !important tag into css. It makes it less flexible.
Can you give an example when problems can't be resolved by including this styles after other css?

@TimKlein87
Copy link

@zavoloklom, First, thank you for your great contributions!

I don't like the !important tag on base css files either, but i'm running into the following problem with angular/material (an example for a FAB button on https://material.angularjs.org/latest/demo/button):

<button class="md-fab md-button md-ink-ripple" aria-label="Label">
    <md-icon class="zmdi zmdi-flower-alt zmdi-hc-2x mdc-text-amber" aria-hidden="true"></md-icon>
</button>

Angular material overrides the color because of the in-page style-tags. How about a material-design-color-palette.important(.min).css file for these cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants