Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dimension_names key to V3 array_metadata #1516

Closed
jhamman opened this issue Sep 6, 2023 · 3 comments
Closed

Add dimension_names key to V3 array_metadata #1516

jhamman opened this issue Sep 6, 2023 · 3 comments
Labels
V3 Affects the v3 branch
Milestone

Comments

@jhamman
Copy link
Member

jhamman commented Sep 6, 2023

The V3 spec included a new array metadata field (dimension_names) to specify the names of the axes corresponding to each dimension in an array. This field should be added to the Array constructor and related utilities.

@jhamman jhamman converted this from a draft issue Sep 6, 2023
@jhamman jhamman added the V3 Affects the v3 branch label Sep 6, 2023
@tasansal
Copy link
Contributor

@jhamman I'll take a stab at this. Can you elaborate on what the "related utilities" are?

@jhamman
Copy link
Member Author

jhamman commented Oct 24, 2023

@tasansal - we may want to hold on this until some internal refactors land on #1290. We are currently exploring the best path to bringing this library up to spec and are considering pulling in some of the internal work sitting in Zarritta. That lib already has the dimension names attribute so if we pull the V3Array class over, this will come for free.

I definitely don't want to wave you off of contributions here though so don't go far! There is lots to do.

@jhamman
Copy link
Member Author

jhamman commented Dec 7, 2023

Closing as this is now done on the v3 branch. See #1583 for more context on the v3 effort.

p.s. @tasansal - would be happy to get your 👀 on the above design doc.

@jhamman jhamman closed this as completed Dec 7, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Zarr-Python - 3.0 Dec 7, 2023
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3 Affects the v3 branch
Projects
Status: Done
Development

No branches or pull requests

2 participants