-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile always rebuilds the libraries #13
Comments
Unfortunately, I don't have the cycles to look into this at the moment, but I'd be happy to take a PR if someone does :-) |
Here's the source of the problem: http://stackoverflow.com/q/32386112/1091116 |
Here's a partial fix that doesn't remove the symlinks on "make clean": diff --git a/src/build_so.sh b/src/build_so.sh
index dc2e1f1..d6386ea 100755
--- a/src/build_so.sh
+++ b/src/build_so.sh
@@ -27,4 +27,5 @@ shift 2
$CC $IN -o $OUT -shared $OPTS "$@" &&
mkdir -p ../$MACHINE &&
-mv $OUT ../$MACHINE/
+rm -f ../$MACHINE/$OUT &&
+ln -s ../src/$OUT ../$MACHINE/ |
Ah, but this way it won't support building multiple architectures in the same checked out repository :-( |
What's your workflow? Perhaps this should be done by "make install"? |
I think just removing the move from build.sh and having it done by "make dist" would be perfect, actually. Good idea! |
Ok, I ended up rewriting the whole makefile so that we don't need Doing |
Would be solved by #46 |
This is probably an easy fix - I used to find myself hacking preeny for my own needs quite a lot once and I found it a bit annoying that "make" would try to rebuild all of the libraries even if I changed just one. Tested on Fedora 21.
The text was updated successfully, but these errors were encountered: