Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note vs discussion comment difference #732

Open
prarit opened this issue Aug 20, 2021 · 0 comments
Open

note vs discussion comment difference #732

prarit opened this issue Aug 20, 2021 · 0 comments

Comments

@prarit
Copy link
Collaborator

prarit commented Aug 20, 2021

I noticed this while working on the commit comment code but felt it was slightly out of scope for that changeset.

When you start a comment with 'mr note' lab adds, for example:


# This comment is being applied to OPEN Merge Request 1166 commit ee6d5ceeadc8f6d8e71a565bb50fcff5e98992fa.
# Do not delete patch tracking lines that begin with '|'.
# Write a message for this note. Commented lines are discarded.

And when you start a discussion with 'mr discussion' lab adds, for example:

# Write a message for this note. Commented lines are discarded.

These really should be the same. I'll work on a changeset today to synchronize the messaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant