Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary remove/re-add of bad nodes #2

Open
zacstewart opened this issue Jun 27, 2017 · 0 comments
Open

Prevent unnecessary remove/re-add of bad nodes #2

zacstewart opened this issue Jun 27, 2017 · 0 comments

Comments

@zacstewart
Copy link
Owner

zacstewart commented Jun 27, 2017

Instead of ejecting bad nodes and potentially having them re-added later, we should just stop using them, and if they become good again, use them then.

The problem is that slow nodes may fail to respond to queries and thus become bad and get rejected. They may eventually respond, but by that time, we're not expecting their response so we discard it.

It also produces a lot of volatility in the network with constant re-introduction of nodes.

This will make updating the socket addr of dead nodes important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant