Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why raise when no changes should result in a new release version? #48

Open
bdubaut opened this issue Apr 17, 2021 · 2 comments
Open

Why raise when no changes should result in a new release version? #48

bdubaut opened this issue Apr 17, 2021 · 2 comments

Comments

@bdubaut
Copy link

bdubaut commented Apr 17, 2021

Hi,

I've been trying to use git_ops in one of my project's release pipeline, and I am surprised that when I push a chore commit (or something that should not create a version bump), the mix task completes with a status code of 1, therefore failing the workflow. Since there's no version to be determined, isn't that expected behaviour? Could we just log it instead and continue?

@zachdaniel
Copy link
Owner

Hello! Originally the design for this was for manual usage, so if you wanted to build a release but nothing would warrant a release, it should stop and tell you. I think there are valid scenarios for each (e.g if you want to push a new image, but only if a new release would happen, a non-zero exit status could be not what you want).

I'd be happy to accept a PR that adds a flag to get the behavior you're looking for though, because your use case makes perfect sense as well.

Right now we have a --yes to take out the interactiveness, so we could also have another to get this behavior. Unsure what the best name would be, but I'm open to ideas. The feature should be really easy to implement.

This was referenced Apr 18, 2021
@thiagomajesk
Copy link

I can confirm that this is the expected behavior for my use case. I have a Gitlab CI pipeline that only allows prod deploys to be run once we have released our code, so if we don't have anything to ship (feats or fixes) we basically can't deploy to production. This forces the team to work with at least one fix or feat per release which actually ships value to our customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants