Make unifiedSecret keys configurable, support setting of non-"public" Postgres Schema #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding the keys for the "unifiedSecret" to access the Postgresql database, I have made all of them configurable, to also work with possible other database operators other than CNPG and PGO, and any already existing secret containing database connection related settings. Due to the newly introduced values, there is no blocking change for existing users, as I do default back to the formerly hardcoded keys.
Additionally to that, I have made the postgresql "schema" configurable, for both methods using the unified secret or supplying the database related configuration settings directly in
values.yaml. The support of a schema other than "public" is only available when.Values.postgresql.enabledis set tofalse, meaning an external (already existing) database is being used. The reason for that is that the official postgres image does not support setting a schema, so it doesn't make sense to have it configured for Zabbix in such a setup, either.I have done tests with and without native Zabbix Server High Availability enabled and made sure the schema setting works in both cases.
Which issue this PR fixes
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]