Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution with source fails to build #571

Open
abekornelis opened this issue Sep 15, 2024 · 1 comment
Open

Distribution with source fails to build #571

abekornelis opened this issue Sep 15, 2024 · 1 comment

Comments

@abekornelis
Copy link
Collaborator

abekornelis commented Sep 15, 2024

When installing z390 from the downloaded distribution file with source code, the build procedure executes RELVER.BAT
This procedure in turn - when git is not installed - fails the build procedure.
In order for a git-less environment to be able to build z390, the RELVER.BAT should ask whether to proceed or abort.
When proceeding, it should use the z390.properties in the distribution file, but it's not yet included.
So the build for the distribution needs to be modified to include the z390.properties file.

When git is installed, a different error is produced by RELVER.BAT, equally preventing the build from succeeding.
For any error encountered, RELVER.BAT should give the option of terminating, or continuing as if FORCE had been provided.
But this does require z390.properties to be included in the distro.

@abekornelis abekornelis changed the title Distribution with source fails to build when git not installed Distribution with source fails to build Sep 15, 2024
@abekornelis
Copy link
Collaborator Author

Required changes include at least:
for BUILD.BAT:

call bat\bldjar         %z_TraceMode% %1       || goto error

for bat\RELVER.BAT:

:final
if %z_Version% EQU "Uncontrolled" (if /I "%1" NEQ "FORCE" (echo Version is uncontrolled - add FORCE parm to ignore
                                                           set z_ReturnCode=8
                                                           goto return
                                                   ) else (echo Version is uncontrolled - FORCE enabled
                                                           if exist z390.properties goto return
                                   )                       )
rem relver: use git to set z390.properties version details
echo z390 version %z_Version%
echo version=%z_Version%> z390.properties
set z_ReturnCode=0

for z390.properties:

version=v1.7.06-261-gd530e8a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant