Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: cannot load zsh-edit #300

Open
2 of 3 tasks
ittayd opened this issue Jan 28, 2024 · 1 comment
Open
2 of 3 tasks

[bug]: cannot load zsh-edit #300

ittayd opened this issue Jan 28, 2024 · 1 comment
Assignees
Labels
bug 🐞 Inconsistencies or issues which will cause a problem for users or implementors. no-stale 🔒 This is exempt from the stale bot triage 📑 The issue is awaiting investigation.

Comments

@ittayd
Copy link

ittayd commented Jan 28, 2024

Environment

?

Reproduction steps

`zi light @marlonrichert/zsh-edit` gives this error:

(anon):11: command not found: zsh-edit
(anon):unfunction:13: no such hash table element: zsh-edit

This seems to be because the shadowing autoload doesn't behave exactly like autoload. I can see there's still shadowing because zi report marlonrichert/zsh-edit outputs:

Report for marlonrichert/zsh-edit plugin
----------------------------------------
Source zsh-edit.plugin.zsh (no reporting)
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/bind with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/zsh-edit with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/.edit.execute-cmd with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/.edit.find-replace with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/.edit.insert-word with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/.edit.move-word with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/_edit._show_clipboard with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/.edit.visual-yank with options -U -z
Autoload /home/ittay/.local/share/zinit/plugins/marlonrichert---zsh-edit/functions/zsh-edit with options -U -z
Autoload add-zsh-hook with options -U -z
Autoload zsh-edit-precmd

Completions:
_bind [enabled]
_edit._show_clipboard [enabled]

Note that even if I add a separate autoload -Uz $fdir/zsh-edit in the plugin file, then still functions like .edit.move-word that are expected are not defined.

I think there are two bugs here:

  1. the shadowed autoload is not compatible with the builtin
  2. light mode doesn't turn off shadowing.

Note that this happens also if I take a fresh .zshrc after just zi installation



### Expected behavior

```bash
see above

Current behavior

see above

Code snippet

?

Additional information

?

Self-service

  • I'd be willing to address this documentation request myself.

Have you read the Contributing Guidelines?

Are you familiar with the Contributor Covenant Code of Conduct?

Contact Details

No response

@ittayd ittayd added bug 🐞 Inconsistencies or issues which will cause a problem for users or implementors. triage 📑 The issue is awaiting investigation. labels Jan 28, 2024
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale 👻 No activity for quite some time. label Feb 28, 2024
@ss-o ss-o added no-stale 🔒 This is exempt from the stale bot and removed stale 👻 No activity for quite some time. labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Inconsistencies or issues which will cause a problem for users or implementors. no-stale 🔒 This is exempt from the stale bot triage 📑 The issue is awaiting investigation.
Projects
None yet
Development

No branches or pull requests

2 participants