Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Fixed compatibility with [email protected] #25

Closed
wants to merge 2 commits into from
Closed

Fixed compatibility with [email protected] #25

wants to merge 2 commits into from

Conversation

uulaal
Copy link

@uulaal uulaal commented Sep 25, 2021

There are some minor fixes that are compatible with old ^21.8.11 and with new ~22.0.6. Only fork.spec.ts results with more failed tests, but as I can see it's not crucial. Also I've tried to fix compatibilty with ~22.1.0 but there are some internal changes in createUnit that I can't understand so far.

Breaking changes in 22.0.0: commit c0f8c9d6308b53635714ac22509602f022b5b254 file createEffect.ts

Breaking changes in 22.1.1: commit f166f7f53ac7f269ddaee5aae06aa760a7f13d0d file createUnit.ts line 340. If this line is removed, everything works fine.

dependabot bot and others added 2 commits September 21, 2021 15:27
Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/daaku/nodejs-tmpl/releases)
- [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5)

---
updated-dependencies:
- dependency-name: tmpl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@yumauri
Copy link
Owner

yumauri commented Sep 26, 2021

Hello!
Thank you so much for contribution!

Just as I can tell, things are bit deeper than that.
@AlexandrHoroshih is working on compatibility with version 22 now, I suggest to wait for it:
https://github.com/AlexandrHoroshih/effector-reeffect/tree/feat/22-compat

@yumauri
Copy link
Owner

yumauri commented Sep 26, 2021

#26

@yumauri yumauri closed this Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants