Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sample-apps] Update YB Sample Apps to support cert and key for YSQL. #5599

Open
Arnav15 opened this issue Sep 4, 2020 · 1 comment · May be fixed by yugabyte/yb-sample-apps#36
Open

[sample-apps] Update YB Sample Apps to support cert and key for YSQL. #5599

Arnav15 opened this issue Sep 4, 2020 · 1 comment · May be fixed by yugabyte/yb-sample-apps#36
Assignees
@tedyu
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@Arnav15
Copy link
Contributor

Arnav15 commented Sep 4, 2020 •
edited by yugabyte-ci
Loading

Jira Link: DB-2067
Currently our sample apps don't support flags to provide a cert and a key file to connect to the YSQL endpoint. We have a flag called ssl_cert for YCQL connections. We can modify that flag to be called ycql_cert and add two new flags called ysql_cert and ysql_key [docs].
The cert then needs to be passed while making the jdbc connection here: https://github.com/yugabyte/yb-sample-apps/blob/master/src/main/java/com/yugabyte/sample/apps/AppBase.java#L148
The flags for the Connection class are here
@Arnav15 Arnav15 added the area/ysql Yugabyte SQL (YSQL) label Sep 4, 2020
@bmatican bmatican removed their assignment Sep 4, 2020
@tedyu
Copy link
Contributor

tedyu commented Sep 5, 2020

What would be proper value for sslmode when cert and key are passed to Connection ?

Thanks

@tedyu tedyu linked a pull request Sep 5, 2020 that will close this issue
Open
@m-iancu m-iancu added this to YQL-beta Dec 7, 2021
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 9, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tedyu tedyu

Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
YQL-beta
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support of cert and key for YSQL tedyu/yb-sample-apps
4 participants
@tedyu @bmatican @Arnav15 @yugabyte-ci