Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition Coordinator should be replaced with UIViewControllerTransitionCoordinator #5

Open
asowers1 opened this issue Apr 7, 2016 · 0 comments

Comments

@asowers1
Copy link
Contributor

asowers1 commented Apr 7, 2016

Instead of our custom implementation we should adopt the UIKit provided UIViewControllerTransitionCoordinator.

UIKit requires timing values for animation, we use spring animations which inherently don't have a specific duration. These should be estimated to look good when animating alongside the built-in transitions.

I've observed in the main Karma app that a duration of 0.2s seems to work.

@asowers1 asowers1 closed this as completed Apr 7, 2016
@asowers1 asowers1 reopened this Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant