Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django(>v4) Support #198

Closed
wy-z opened this issue Dec 7, 2023 · 4 comments
Closed

Django(>v4) Support #198

wy-z opened this issue Dec 7, 2023 · 4 comments

Comments

@wy-z
Copy link
Contributor

wy-z commented Dec 7, 2023

I noticed the latest version doesn't support Django>4. Could you clarify if this is permanent or if there are plans to reintroduce Django support in the future?

Thanks for your efforts and looking forward to your response.

@wy-z
Copy link
Contributor Author

wy-z commented Dec 7, 2023

Could we consider removing all support for django.cache_page and just keeping django.cache? After all, django.cache_page is specific to Django and not a common caching method.
I'd like to express my gratitude again; if it's convenient for you, please consider my suggestion. @youknowone

@youknowone
Copy link
Owner

youknowone commented Dec 8, 2023

Hi. I didn't use Django for long time. I don't think I have a proper opinion for it. What will be the best solution? I'd like to follow your suggestion.

@wy-z
Copy link
Contributor Author

wy-z commented Dec 8, 2023

I also submitted a PR to fix support for Django v4 (see #199, reference encode/django-rest-framework#7513) .
Please review it when convenient, much appreciated 🙏.

@wy-z
Copy link
Contributor Author

wy-z commented Dec 22, 2023

Fixed by #199

@wy-z wy-z closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants