Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Cluster Service for secure and restricted communication during document detach on Client Deactivation #1038

Open
raararaara opened this issue Oct 18, 2024 · 0 comments
Labels
enhancement 🌟 New feature or request

Comments

@raararaara
Copy link
Contributor

What would you like to be added:
In PR #1036, logic for document detachment during Client Deactivation was introduced. As Yorkie's documents are distributed across servers based on shard keys, a Cluster Server was needed for inter-cluster communication during deactivation. However, there are still critical issues that need addressing:

  1. Authentication: Since the client may require a token for authentication, we need a structure for authentication during server-to-server communication. It’s important to ensure that communication between servers is secure.

  2. External Call Restrictions: The logic within ClusterService should only be used for inter-server communication. We need to establish methods to restrict external calls or entirely prevent exposure to enhance security.

Why is this needed:
These enhancements will provide a secure and controlled environment for document operations during client deactivation, significantly reducing potential security risks associated with unauthenticated access and improper external calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant