Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate SourceMap for Sentry and resolve TypeScript version conflict with ESLint #384

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

devleejb
Copy link
Member

@devleejb devleejb commented Oct 25, 2024

What this PR does / why we need it:

This PR activates SourceMap generation for Sentry, which was not uploading correctly due to previous misconfigurations. The settings have been corrected to ensure that SourceMaps are now generated and deployed properly.

Additionally, this PR addresses a TypeScript version conflict with ESLint, ensuring that both can work seamlessly together.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The incorrect settings for SourceMap upload to Sentry were causing difficulties in tracking errors effectively. Ensuring the proper generation and configuration allows us to better debug and monitor the application in production.

Furthermore, resolving the TypeScript version conflict eliminates potential issues arising from mismatched versions, thus smoothing the development process.

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • New Features

    • Updated linting scripts to allow warnings without failing the process.
    • Enhanced sourcemap generation for easier debugging.
  • Bug Fixes

    • Upgraded dependencies for improved linting and parsing in TypeScript files.
  • Documentation

    • Comments added for potential future sourcemap asset management functionality.

Copy link
Contributor

coderabbitai bot commented Oct 25, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes updates to the package.json and vite.config.ts files within the frontend project. Changes to package.json involve modifications to scripts and upgrades of specific development dependencies, including eslint-plugin-react-hooks and TypeScript-related packages. The vite.config.ts file has been altered to always enable sourcemap generation, simplifying the configuration by removing conditional logic based on environment variables.

Changes

File Change Summary
frontend/package.json - Updated lint script to remove --max-warnings 0 option.
- Upgraded eslint-plugin-react-hooks from ^4.6.0 to ^5.0.0.
- Upgraded @typescript-eslint/eslint-plugin from ^8.7.0 to ^8.11.0.
- Upgraded @typescript-eslint/parser from ^8.7.0 to ^8.11.0.
frontend/vite.config.ts - Changed sourcemap property to always be true, removing conditional logic based on env vars.

Possibly related PRs

Poem

🐰 In the garden where code does bloom,
Dependencies dance, dispelling the gloom.
Linting's now kinder, with warnings allowed,
Sourcemaps shining, we sing it out loud!
With each little change, our project takes flight,
Hopping along, coding feels just right! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@devleejb devleejb merged commit 204dc3e into main Oct 25, 2024
2 checks passed
@devleejb devleejb deleted the enable-sourcemap branch October 25, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant