-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Prometheus metrics #87
Conversation
adding option for "exporter"
@loaynaser3 @yonahd |
also, it's probably best to source the time interval from an environment variable, allowing for easy changes from the helm chart. |
Let's put the chart changes in a separate PR |
+1 |
get exporter interval from env var otherwise default value vars is exporterInterval + updating README
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 49.36% 42.82% -6.54%
==========================================
Files 15 17 +2
Lines 1493 1749 +256
==========================================
+ Hits 737 749 +12
- Misses 657 898 +241
- Partials 99 102 +3
☔ View full report in Codecov by Sentry. |
@loaynaser3 Looking over the implementation now. |
@yonahd i thought of this scenario but i didnt see the use of it. |
Ok. Let's keep it this way for now. |
@yonahd yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loaynaser3 Looks good.
A couple small comments
@loaynaser3 Can you also change the name of the pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
adding option for "exporter"
this is an initial PR, simple way of exporting metrics
@yonahd , @Yuni-sa how you think we should proceed from here ?