Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Support for Argo Rollouts #363

Closed

Conversation

oliveiraxavier
Copy link

What this PR does / why we need it?

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

This PR adds support for rollout type types (Argo Rollouts)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 30.24390% with 143 lines in your changes missing coverage. Please review.

Project coverage is 43.65%. Comparing base (673c21e) to head (1babf0e).

Files with missing lines Patch % Lines
pkg/kor/delete.go 1.53% 64 Missing ⚠️
pkg/kor/argorollouts.go 54.16% 15 Missing and 7 partials ⚠️
pkg/kor/all.go 11.76% 15 Missing ⚠️
cmd/kor/argorollouts.go 0.00% 10 Missing ⚠️
pkg/kor/kor.go 0.00% 10 Missing ⚠️
pkg/kor/exporter.go 0.00% 7 Missing ⚠️
pkg/kor/multi.go 40.00% 6 Missing ⚠️
cmd/kor/all.go 0.00% 2 Missing ⚠️
cmd/kor/deployments.go 0.00% 2 Missing ⚠️
cmd/kor/exporter.go 0.00% 2 Missing ⚠️
... and 2 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   44.48%   43.65%   -0.84%     
==========================================
  Files          63       65       +2     
  Lines        3356     3530     +174     
==========================================
+ Hits         1493     1541      +48     
- Misses       1622     1741     +119     
- Partials      241      248       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd
Copy link
Owner

yonahd commented Oct 16, 2024

I like the direction of this PR, still need to get around to a code review...
On a more general level,

  • I want to put the crds code in a separate folder than the regular resources
  • when calling kor all I want to only show native resources and show cords using a flag --include-crds
  • we need to make sure kor doesn't crash when this crd doesn't exist in the cluster

@oliveiraxavier
Copy link
Author

Gosto da direção deste PR, ainda preciso fazer uma revisão de código... Em um nível mais geral,

  • Quero colocar o código crds em uma pasta separada dos recursos regulares
  • ao chamar, kor allquero mostrar apenas recursos nativos e mostrar cordões usando um sinalizador--include-crds
  • precisamos ter certeza de que o kor não travará quando este crd não existir no cluster

I understood. I liked your idea. Can I work on this? If you agree, I will close this PR

@yonahd
Copy link
Owner

yonahd commented Oct 17, 2024

Gosto da direção deste PR, ainda preciso fazer uma revisão de código... Em um nível mais geral,

  • Quero colocar o código crds em uma pasta separada dos recursos regulares
  • ao chamar, kor allquero mostrar apenas recursos nativos e mostrar cordões usando um sinalizador--include-crds
  • precisamos ter certeza de que o kor não travará quando este crd não existir no cluster

I understood. I liked your idea. Can I work on this? If you agree, I will close this PR

Yes. You can make these changes in this PR and this will be the first crd

@oliveiraxavier oliveiraxavier mentioned this pull request Nov 5, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants