Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need lr scheduler? #274

Open
Dforgeek opened this issue Jul 25, 2024 · 3 comments
Open

Do we need lr scheduler? #274

Dforgeek opened this issue Jul 25, 2024 · 3 comments

Comments

@Dforgeek
Copy link

In all repository, I didn't find any place where scheduler.step() was used in training. Should it be this way?

@martinambrus
Copy link

I've found step() function of scheduler being used on these lines: https://github.com/yl4579/StyleTTS2/blob/main/optimizers.py#L43-L45

Also, the lr_scheduler is being used here: https://github.com/yl4579/StyleTTS2/blob/main/optimizers.py#L54

All of that is used in imports of all training scripts as from optimizers import build_optimizer.

@Dforgeek
Copy link
Author

Dforgeek commented Sep 2, 2024

It is true that there's single place where .step() is being called, иut the method .scheduler() in which .step() is called has never been used for any of the training scripts. So I think it's not used.

@ethan-digi
Copy link

I can confirm, at least for train_finetune.py, that the lrs are not adjusted for any of the models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants