You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 12, 2019. It is now read-only.
Idea/Suggestion about CSS naming rules/refactoring:
Javascripts files that use css selectors are
./renderer-process/content-loader.js
./renderer-process/search-view.js
./renderer-process/favorite-view.js
./renderer-process/read-view.js
./renderer-process/view-switcher.js
The text was updated successfully, but these errors were encountered:
yjlintw
changed the title
CSS selector Refactoring
CSS selector fefactoring
Apr 18, 2017
yjlintw
changed the title
CSS selector fefactoring
CSS selector refactoring
Apr 18, 2017
Which are the View-Controllers I have mentioned in the WIKI page (and only View-Controllers should be allowed to access css-selectors)
It would be nice if you can change the selectors in those file when we are doing the refactoring
@fuluboy I think at this moment, you are the most experienced front-end developer among this team. I think you can go ahead and decide the naming rules. It would be nice if you can give us a naming rule guidelines that everyone can follow.
I think naming rules/refactoring should be done as early as possible (am I right?). Let us know if you need any help.
@fuluboy as I am implementing the subscription update at this moment. The favorite entry in the favorite view will need a class called .hasupdate(or something similar) which will affect the UI so the user can know that subscribed comic has new updates.
Right now I just change the background color because it is easy to implement and test. We can change the indicator later.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Idea/Suggestion about CSS naming rules/refactoring:
Javascripts files that use css selectors are
./renderer-process/content-loader.js
./renderer-process/search-view.js
./renderer-process/favorite-view.js
./renderer-process/read-view.js
./renderer-process/view-switcher.js
The text was updated successfully, but these errors were encountered: