-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Play with docker" integration #654
Comments
Looking into that problem. For play with docker to work, all docker images and the code should be already inside containers. The containers should be compiled and pushed to https://hub.docker.com. So there should be constant docker images compilation to create containers with the current code, or compilation should be done per release. Correct me if I am wrong. |
correct
not correct (at least not necessary), we could use a service like Gitlab too.
Yes and no. Yes, we should have image compilation (for testing and release purposes), but is not necessary for the Play With Docker (PWD) service. Play with docker runs with docker-compose files, so there's no limitations in how we build the images. See this advanced PWD example file: https://raw.githubusercontent.com/vegasbrianc/prometheus/version-2/pwd-stack.yml and compare it to the "development" docker-compose file: https://raw.githubusercontent.com/vegasbrianc/prometheus/version-2/docker-compose.yml Here's a diff comparing the files: https://www.diffchecker.com/r5A0IIME (left: The problem with this is the time to test and try this stuff. If someone is willing to send a PR, I would be glad to review it. |
…ory. Testing pwd compose file.
…command in docker-compose.
…st is not specified.
…at PWD runs composer install in background, so need to wait about 60 seconds for the application to start.
#676 Here is the PR. |
…D button to readme.
Will look at this once more when have some free time. |
https://medium.com/@patternrecognizer/how-to-add-a-try-in-play-with-docker-button-to-your-github-project-41cb65721e94
The text was updated successfully, but these errors were encountered: