Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShapeNetV2 bug in generating splits? #17

Open
berendbaas opened this issue Sep 30, 2020 · 0 comments
Open

ShapeNetV2 bug in generating splits? #17

berendbaas opened this issue Sep 30, 2020 · 0 comments

Comments

@berendbaas
Copy link

berendbaas commented Sep 30, 2020

Hi there,
Thanks for your interesting work and sharing your code.

I ran into a small issue into train/test split generation in ShapeNetV2. You might want to be aware, in case you're reusing the code in the future

When a shuffled train-test split for a shape category does not exist, the code seems to iterate over all categories listed in synsetoffset2category.txt(they get loaded into self.numbercat2namecat). It then creates a train/test split out of a concatenation of all these categories.

for k in self.numbercat2namecat:

I suspect the intended behaviour was to create a train/test split for only a single category for each non-existing split-file? (As the filename contains the id of the category it's supposed to contain the split for).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant