You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FarCall_:
ld [wFarCallHold + 0], a
put [wFarCallHold + 1], h
put [wFarCallHold + 2], l
[ ... ]
ld hl, wFarCallHold + 1
ld a, [hli]
ld h, [hl]
ld l, a
This ends up swapping h and l
Could just putl before h
Also, at the end, this bit attempts to save the potential return value in a and/or f while pulling the rom bank off the stack, but leaves a hole in the stack:
push af
add sp, 2
pop af ; hROMBank
add sp, -4
rst Bankswitch
pop af
ret
It needs an extra add sp, 2 at the end:
push af
add sp, 2
pop af ; hROMBank
add sp, -4
rst Bankswitch
pop af
add sp, 2
ret
The text was updated successfully, but these errors were encountered:
In this snippet from rst.asm:
This ends up swapping
h
andl
Could just
put
l
beforeh
Also, at the end, this bit attempts to save the potential return value in
a
and/orf
while pulling the rom bank off the stack, but leaves a hole in the stack:It needs an extra
add sp, 2
at the end:The text was updated successfully, but these errors were encountered: