Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ring middleware doesn't correctly parse referer and user-agent headers #6

Open
mveytsman opened this issue Feb 25, 2016 · 1 comment
Open

Ring middleware doesn't correctly parse referer and user-agent headers #6

mveytsman opened this issue Feb 25, 2016 · 1 comment

Comments

@mveytsman
Copy link

The yeller ring middleware looks for the keys "Referer" and "User-Agent" in the request headers (https://github.com/yeller/yeller_clojure/blob/master/src/yeller/clojure/ring.clj#L6-L9)

Ring actually lowecases the header names. See the spec here: https://github.com/mmcgrana/ring/blob/master/SPEC#L83-L86

Yeller should be looking for "referer" and "user-agent".
@mveytsman mveytsman changed the title Ring middleware doesn't correctly parse referrer and user-agent Ring middleware doesn't correctly parse referrer and user-agent headers Feb 25, 2016
@mveytsman mveytsman changed the title Ring middleware doesn't correctly parse referrer and user-agent headers Ring middleware doesn't correctly parse referer and user-agent headers Feb 25, 2016
@tonsky
Copy link

tonsky commented Apr 25, 2016

@mveytsman I was stumbling across the same issue just today :(
@tcrayford any chance we see a release with that change merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mveytsman @tonsky