fix_rollback_handling: don't send commit on server side YDB errors #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavrukov
commented
Mar 5, 2024
repository-ydb-v2/src/main/java/tech/ydb/yoj/repository/ydb/YdbRepositoryTransaction.java
Show resolved
Hide resolved
lavrukov
commented
Mar 5, 2024
repository-ydb-v2/src/main/java/tech/ydb/yoj/repository/ydb/client/YdbValidator.java
Show resolved
Hide resolved
lavrukov
commented
Mar 5, 2024
| @@ -103,6 +103,42 @@ public static void validate(String request, StatusCode statusCode, String respon | |||
| } | |||
| } | |||
|
|
|||
| public static boolean isServerSideError(StatusCode statusCode) { | |||
| return switch (statusCode) { | |||
| case UNUSED_STATUS, | |||
There was a problem hiding this comment.
question: do we have to skip rollback on UNUSED_STATUS too?
alex268
approved these changes
Mar 5, 2024
nvamelichev
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.