Better YDB Mapping Defaults (opt-in) #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`ChangefeedEntity` has `initialScan=true`
…se don't honor the `@Column` annotation ...Stop using these methods in all tests but the `YqlTypeAllTypesTest`
…Instant <-> TIMESTAMP. Make Duration<->INTERVAL mapping the default Please call `YqlPrimitiveType.useRecommendedMappingFor(STRING, ENUM, TIMESTAMP)` in all new projects. This will become the default in a future version of YOJ.
nvamelichev
force-pushed
the
better-ydb-mapping-defaults-opt-in
branch
from
a7d14ee to
af36fa9
Compare
lavrukov
reviewed
Feb 21, 2024
| * @param fieldValueTypes field value types to use the new mapping for | ||
| */ | ||
| @ExperimentalApi(issue = "https://github.com/ydb-platform/yoj-project/issues/20") | ||
| public static void useRecommendedMappingFor(FieldValueType... fieldValueTypes) { |
There was a problem hiding this comment.
nitpick: looks little bit strange: useLegacyMappingFor is deprecated, but useRecommendedMappingFor is experimental. Where is a correct way to set mappings?
lavrukov
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.