Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for string value types with single-argument String constructor #25

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

anaym
Copy link
Contributor

@anaym anaym commented Feb 14, 2024

No description provided.

@nvamelichev nvamelichev changed the title Add support for StringValueType without fromString/valueOf methods Add support for StringValueType with single-argument String constructor Feb 14, 2024
Copy link
Collaborator

@nvamelichev nvamelichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor request: remove extraneous null check, please

@nvamelichev nvamelichev changed the title Add support for StringValueType with single-argument String constructor Support for string value types with single-argument String constructor Feb 14, 2024
@nvamelichev nvamelichev merged commit 112f9d6 into ydb-platform:main Feb 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants