ByteArray class for primary keys with byte[] #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavrukov
commented
Feb 1, 2024
lavrukov
changed the title
lavrukov
force-pushed
the
byte-array-pk-keys
branch
from
8cd72cd to
0aa2cbf
Compare
nvamelichev
requested changes
Feb 2, 2024
There was a problem hiding this comment.
Overall very good!
I request some minor improvements
- Add another (convenience) copy constructor to
ByteArray, it will make the test so much nicer:
var copy = ByteArray.copy(ba); // copies ByteArray's bytes :-)
var copy2 = ba.copy(); // same as ByteArray.copy(ba), just alternative syntax- Add tests for
ByteArray-keyed entities toListingTestandTableQueryBuilderTest(to testTable.list()andTable.query()DSL explicitly)
Other than that, I think the PR is great!
| } else if (value.isByteArray()) { | ||
| checkArgument(fieldValueType == FieldValueType.BYTE_ARRAY, | ||
| ByteArrayFieldExpected::new, | ||
| p -> format("Specified a boolean value for non-boolean field \"%s\"", p)); |
There was a problem hiding this comment.
Typo: "boolean value", "non-boolean field" instead of "ByteArray value", "non-ByteArray field"
nvamelichev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Byte arrays in primary keys support.
We can't do it with simple byte[], because records default comparator and equals uses compare adresses, not real data. Special class for this looks better, than magic over byte[]