Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send rollback on server errors #40

Closed
lavrukov opened this issue Mar 5, 2024 · 0 comments · Fixed by #41
Closed

Don't send rollback on server errors #40

lavrukov opened this issue Mar 5, 2024 · 0 comments · Fixed by #41
Assignees
@lavrukov
Labels
bug Something isn't working

Comments

@lavrukov
Copy link
Contributor

lavrukov commented Mar 5, 2024

All tech.ydb.core.StatusCode except {SUCCESS, TRANSPORT_UNAVAILABLE, CLIENT_*} means that YDB already invalidate a tx and rollback in this case isn't needed
@lavrukov lavrukov closed this as completed Mar 6, 2024
@lavrukov lavrukov self-assigned this Mar 6, 2024
@lavrukov lavrukov added the bug Something isn't working label Mar 6, 2024
@lavrukov lavrukov linked a pull request Mar 6, 2024 that will close this issue
fix_rollback_handling: don't send commit on server side YDB errors #41
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lavrukov lavrukov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix_rollback_handling: don't send commit on server side YDB errors ydb-platform/yoj-project
1 participant
@lavrukov