Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batches in result in unexpected order #70

Open
bozhou opened this issue Oct 10, 2018 · 0 comments
Open

Batches in result in unexpected order #70

bozhou opened this issue Oct 10, 2018 · 0 comments

Comments

@bozhou
Copy link

bozhou commented Oct 10, 2018

https://github.com/yatish27/salesforce_bulk_api/blob/master/lib/salesforce_bulk_api/job.rb#L182-L185
comes from this PR
@batch_ids.delete(batch_id) does not work very well with the each, since Array#each use indices to iterate.

I'm wondering since batches_ready is true, why not remove the break if @batch_ids.empty? and @batch_ids.delete(batch_id) logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bozhou