Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same script in another pages(streamcloud, netflix, hulu, amazon instant video, etc...) #23

Open
leocaseiro opened this issue Apr 19, 2016 · 1 comment

Comments

@leocaseiro
Copy link
Contributor

leocaseiro commented Apr 19, 2016

Hi @yashagarwal1411, first of all, many thanks for this plugin. It's really good. I loved it.

It's easy to search and also the features to sync (Precede/Delay) is AMAZING.

I was wondering if was possible to use similar script to implement in any other player.
Perhaps you have an idea how easy would be to implement in any player. I'm very happy to fork it and try it on my own, but I'm not sure what license is this library as well. Or perhaps, you'd be happy to give me some tips or help in another way.

I was thinking to implement as a popup(so we can edit some setups for any page, instead of prepend/append into html)... Please, let me know your thoughts.

Thanks.

@yasheltropy
Copy link
Contributor

Hey @leocaseiro implementing this as a popup, sounds like a very good idea. I don't have time immediately to implement this but you can give it a try yourself if you want.

The current code just searches for a div on the YouTube page which is used for showing the subtitle text. So if you create a popup with a div and use its id for showing the sub text. I think what you are saying will be achieved. This div id is 'html5-video-container' in Bubbles-modified.js. This is the major change but I guess there will be some other changes as well. We can also get on a call and discuss this more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants