From 25c17f136299700f8252e35344d699fe5085ec0a Mon Sep 17 00:00:00 2001
From: David Blankenship <david.blankenship@yale.edu>
Date: Mon, 30 Sep 2024 15:36:36 -0400
Subject: [PATCH] fix(YSP-559): fix PHP default param deprecation

Looking at the Drupal 10 options_allowed_values signature, $cachable
isn't even there.  This is an attempt to allow this to play nice and not
throw an error or deprecation warning.
---
 .../modules/custom/ys_themes/ys_themes.module                 | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/web/profiles/custom/yalesites_profile/modules/custom/ys_themes/ys_themes.module b/web/profiles/custom/yalesites_profile/modules/custom/ys_themes/ys_themes.module
index 0d4db3f42..af8277d0f 100644
--- a/web/profiles/custom/yalesites_profile/modules/custom/ys_themes/ys_themes.module
+++ b/web/profiles/custom/yalesites_profile/modules/custom/ys_themes/ys_themes.module
@@ -17,15 +17,13 @@ use Drupal\field\Entity\FieldStorageConfig;
  *   The field definition.
  * @param \Drupal\Core\Entity\ContentEntityInterface|null $entity
  *   The entity being created, if applicable.
- * @param bool $cacheable
- *   Boolean indicating if the results are cache-able.
  *
  * @return array
  *   An array of possible key and value options.
  *
  * @see options_allowed_values()
  */
-function ys_themes_allowed_values_function(FieldStorageConfig $definition, ?ContentEntityInterface $entity = NULL, $cacheable) {
+function ys_themes_allowed_values_function(FieldStorageConfig $definition, ?ContentEntityInterface $entity = NULL) {
   $options = [];
   $config = \Drupal::config('ys_themes.component_overrides');