Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore loop and docker network interfaces? #12

Open
xxxserxxx opened this issue Feb 15, 2020 · 2 comments
Open

Ignore loop and docker network interfaces? #12

xxxserxxx opened this issue Feb 15, 2020 · 2 comments
Labels
enhancement New feature or request needs:opinions

Comments

@xxxserxxx
Copy link
Owner

xxxserxxx commented Feb 15, 2020

Currently, virtual network interfaces are included in the total values calculated in the network widget (besides VPN interfaces which have been removed) but I feel like maybe we should just include physical network interfaces like ethernet and wifi.

Original cjbassi#33

@xxxserxxx
Copy link
Owner Author

I believe what should be done instead is cjbassi#20

@xxxserxxx
Copy link
Owner Author

So #20 has been implemented, but it only allows for specifying one interface. #148 has been opened which would allow for specifying a list of interfaces.

So I think the question comes down to what the default should be:

  • Should we only show physical network interfaces by default and require users to opt into showing virtual interfaces too once I can't comment on issue #148 is implemented?
  • Or should we show all interfaces by default (vpn interface too?) and require users to opt out of virtual interfaces?

It might be good to have an option specifically for this. I'd also like to allow for specifying network interfaces to not show: #149.

@xxxserxxx xxxserxxx added the enhancement New feature or request label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs:opinions
Projects
None yet
Development

No branches or pull requests

1 participant