Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styleguide support in the 'undercurrent way' #14

Open
mehigh opened this issue Feb 4, 2018 · 0 comments
Open

Add styleguide support in the 'undercurrent way' #14

mehigh opened this issue Feb 4, 2018 · 0 comments
Assignees

Comments

@mehigh
Copy link
Member

mehigh commented Feb 4, 2018

I attempted to add styleguide support through the regular gulp-controlled methods, but encountered a couple of issues:
1 - When using it using 'the gulp' way I get an error regarding vinylFs (happenes with the latest Gulp version as well) because vinyl 3 is a breaking update and hence causes a critical error for gulp-util which uses vinyl 2.
2 - when attempting to run the sc5-styleguide-cli from inside our flow, "TypeError: gulp.hasTask is not a function" is an error I constantly got and I think this is causing a conflict between Gulp 4 that we're using and Gulp 3.9.1 the sc5-styleguides is using behind the scenes.
gulp = require('gulp') inside styleguide-cli.js ends up pointing to Gulp 4.0.0 which doesn't have .hasTask defined.

This might be worth picking up when the following issue gets fixed:
SC5/sc5-styleguide#1127

For the moment running using the CLI installed globally is the only way I was able to get it to work to avoid the Gulp versions clash.

Even running npm run styleguide triggers the wrong Gulp version to be loaded inside.

@mehigh mehigh self-assigned this Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant