Theme Edits Grayed Out #1658
Open
Theme Edits Grayed Out #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinkrzeminski
changed the title
tharsheblows
requested changes
Dec 23, 2024
There was a problem hiding this comment.
A couple of comments but this looks good. I looked it up and the ajax method was added in 4.9 so I think we're safe? It will still work with < WP 4.9 but won't record the changes.
Should we add a "Requires at least" header? I'm not really sure which version that would be though.
| $this->edited_file = $this->get_plugin_data( $plugin_slug ); | ||
| } | ||
|
|
||
| $this->log_changes( $location ); |
There was a problem hiding this comment.
❓question
If there's no $location here, should we log anything? I don't think so?
There was a problem hiding this comment.
Fixed that.
| ) { | ||
| $action = wp_stream_filter_input( INPUT_POST, 'action' ); | ||
| $request_method = wp_stream_filter_input( INPUT_SERVER, 'REQUEST_METHOD' ); | ||
|
|
There was a problem hiding this comment.
❗️issue
Can you add a nonce and capability check here? I think it can be the same capability check as is required to do the action.
There was a problem hiding this comment.
Fixed that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1657
Use alternative hook to track the theme files updates in the Dashboard.
Checklist
contributing.md).Release Changelog