Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce autoloader #104

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Jun 22, 2023

Fixes a @todo

Tasks

  • One important change that has been implemented.
  • Another thing still left to do.
  • Added PHP tests.
  • Added JS tests.

Describe the Approach

  • fixed prefix of site_performance_tracker_php_version_error
  • moved all functions to the top of the main file to separate definitions from side-effects
  • added xwp_site_performance_autoloader

source

@szepeviktor
Copy link
Contributor Author

@kasparsd I am emotionally unstable. Will you close this one too?

@kasparsd
Copy link
Contributor

kasparsd commented Aug 4, 2023

I'm sorry @szepeviktor! It was definitely not my intention to cause any stress or anxiety with the feedback on the other issues.

We definitely need the autoloader for this. It wasn't initially added because the plugin started as something really small. We have this WPCS compliant autoloader here https://github.com/xwp/io-php-wp-autoload -- I wonder if we could copy-paste that in here?

@szepeviktor
Copy link
Contributor Author

All right. I let you paste that.
What a long class.

I just want to inspire you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants