Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a custom display for the new configuration properties #42 #52

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

ChiuchiuSorin
Copy link
Contributor

Created a new class to include additional properties to the OIDC client class and modified the listener to intercept events update and delete to be able to update the OIDC endpoints in case the tenent id is modified.
Created a custom display for administration in AzureADClientConfigurationSheet. Administration page:

Screenshot from 2024-11-13 18-08-09
Screenshot from 2024-11-13 18-08-24
Screenshot from 2024-11-13 18-09-43

* modified parent  platform version to 14.10-1
* uploaded the documents from an instance of XWiki 14.10
* updated README.md
* checked for keywords and regex
* tested functionalities using Identity OAuth (pro)
# Conflicts:
#	pom.xml
* Created a new configuration for OIDC properties
* Set default values specific to Azure for the new configuration
* Created a java configuration for the old configuration for the old Identity OAuth classes
* Created a listener that copies the old configuration to the newly OIDC configuration


* created a new class to include additioal properties to the OIDC client class and created a new configuration soruce for it
* created AzureADClientConfigurationSheet to use as a custom display inside the administration
* modified the listener to intercept events update and delete to be able to update the OIDC endpoints in case the tenent id is modified
@ChiuchiuSorin ChiuchiuSorin self-assigned this Nov 13, 2024
@ChiuchiuSorin ChiuchiuSorin linked an issue Nov 13, 2024 that may be closed by this pull request
# Conflicts:
#	api/src/main/java/com/xwiki/azureoauth/configuration/AzureConfiguration.java
* created a new configuration class for OIDC
* refactored the listener
* refactored the configuration sources+
# Conflicts:
#	api/src/main/java/com/xwiki/azureoauth/internal/AzureADUpgradingListener.java
#	api/src/main/java/com/xwiki/azureoauth/internal/configuration/DefaultAzureConfiguration.java
#	ui/src/main/resources/AzureAD/AzureADClientConfiguration.xml
#	ui/src/main/resources/AzureAD/AzureADConfigurationClass.xml
@ChiuchiuSorin ChiuchiuSorin marked this pull request as ready for review November 15, 2024 16:31
* replaced DocumentUpdatedEvent with XObjectUpdatedEvent
* removed TODO
* renamed AzureAD to Entra ID
* refactored the initializer
* added unit tests
* code refactoring
# Conflicts:
#	api/src/main/resources/META-INF/components.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a custom display for the new configuration properties
1 participant