-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a custom display for the new configuration properties #42 #52
Open
ChiuchiuSorin
wants to merge
19
commits into
xwikisas:master
Choose a base branch
from
ChiuchiuSorin:iss42
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* modified parent platform version to 14.10-1 * uploaded the documents from an instance of XWiki 14.10 * updated README.md * checked for keywords and regex * tested functionalities using Identity OAuth (pro)
# Conflicts: # pom.xml
* Created a new configuration for OIDC properties * Set default values specific to Azure for the new configuration * Created a java configuration for the old configuration for the old Identity OAuth classes * Created a listener that copies the old configuration to the newly OIDC configuration
* created a new class to include additioal properties to the OIDC client class and created a new configuration soruce for it * created AzureADClientConfigurationSheet to use as a custom display inside the administration * modified the listener to intercept events update and delete to be able to update the OIDC endpoints in case the tenent id is modified
# Conflicts: # api/src/main/java/com/xwiki/azureoauth/configuration/AzureConfiguration.java
* created a new configuration class for OIDC * refactored the listener * refactored the configuration sources+
# Conflicts: # api/src/main/java/com/xwiki/azureoauth/internal/AzureADUpgradingListener.java # api/src/main/java/com/xwiki/azureoauth/internal/configuration/DefaultAzureConfiguration.java # ui/src/main/resources/AzureAD/AzureADClientConfiguration.xml # ui/src/main/resources/AzureAD/AzureADConfigurationClass.xml
* replaced DocumentUpdatedEvent with XObjectUpdatedEvent * removed TODO
* renamed AzureAD to Entra ID * refactored the initializer
* added unit tests * code refactoring
# Conflicts: # api/src/main/resources/META-INF/components.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new class to include additional properties to the OIDC client class and modified the listener to intercept events update and delete to be able to update the OIDC endpoints in case the tenent id is modified.
Created a custom display for administration in AzureADClientConfigurationSheet. Administration page: