Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification about automatic upgrades does not show message about the update done or failed #154

Open
petrenkonikita112263 opened this issue Nov 8, 2023 · 3 comments

Comments

@petrenkonikita112263
Copy link

Prerequisites:

  • XWiki instance 13.10
  • The latest version of the License app
  • Having one of any pro app's initial version or older (for instance, I installed Pro Macros v1.11.0)
  • Logged as admin user
  • Having open in separate tab Licenses page Administer XWiki → Extensions → Licenses

Step to reproduce:

  1. Enable auto-upgrade for an installed pro app from the License page. Administer XWiki → Extensions → Licenses. After enabling it should be green color.
  2. Click on Notifications bell → Settings in Applications section enable Automatic upgrades (or use direct link http://localhost:8080/xwiki/bin/view/XWiki/Admin?category=notifications)
  3. Go to Job Scheduler page via shortcut or direct link http://localhost:8080/xwiki/bin/view/Scheduler/
  4. Trigger both jobs "Licensed extension upgrade" and "New version available" (here, I'm not sure is it enough to trigger only "New version available" or not)
  5. Wait a bit and check 2nd page tab, which you had opened before, refresh it, see a new version number for pro app

Actual result:
Observing a new version number in the license table, the notification won't have information regarding the successful upgrade.

Expected result:
Admin user sees information about recent upgrades in notifications.

@petrenkonikita112263
Copy link
Author

Note that I've also tried, to rollback version of Pro Macros downgrade to v1.11.0 and re-triggered job, but this time I have an enabled notifications. I assume the sequence that must be done first: enable auto upgrade or notification doesn't matter, even on 2nd auto upgrade I still don't receive notification

@petrenkonikita112263 petrenkonikita112263 changed the title Notification about automatic upgrades does show message about the update done or failed Notification about automatic upgrades does not show message about the update done or failed Nov 8, 2023
@oanalavinia
Copy link
Contributor

Please check #88 (comment) . As is said in here, the System filter should also be disabled to be able to receive a notification, since this is send by the superadmin

@petrenkonikita112263
Copy link
Author

The issue is still reproducable, even with disabled notification for Admin user, re-downgrading with further re-triggering job updater → doesn't display notification about the finished upgrade of pro apps. Same is true for normal (non-admin) user who has the disabled type of notification by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants