Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding cannot always work #36

Open
polx opened this issue Nov 19, 2019 · 2 comments
Open

Embedding cannot always work #36

polx opened this issue Nov 19, 2019 · 2 comments

Comments

@polx
Copy link

polx commented Nov 19, 2019

It appears that the embedding function (which relies on the Drive API's embedLink property) cannot work in all cases.

People who have view access on the wiki page may be unauthorized to access the google drive.

There appears to be no way to be warned about this. In principle this would be ok if the user would be understanding that this problem can be solved by changing permissions at Google but thus far I only see a blank page.

@AndreeaChi
Copy link

While testing Google Apps Integration 2.5.2., I noticed that this indeed happens if a user, with only View right given at wiki level, goes to a page that has the Drive macro added and if they try to embed a file, they would be shown that access is denied for them.
image

They would also see a message like Unauthorized Error 401 if they go to a page where there is an embedded document already.

image

@ane-gabriela
Copy link

Issue reproducing on Cloud XWiki 15.10.8 with Google Apps Integration (Pro) 2.6.1 and Chrome 125

EmbedIssue

I think it is also related to #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants