Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XCOMMONS-2349: Improve performance of AttributeFilter in HTMLCleaner #159

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

XCOMMONS-2349: Improve performance of AttributeFilter in HTMLCleaner #159

wants to merge 4 commits into from

Commits on Jun 13, 2022

  1. XCOMMONS-2349: Improve performance of AttributeFilter in HTMLCleaner 

    * Store the XPathExpression in a thread-local variable.

Note: this will lead to memory leaks if threads are re-used for other applications after stopping XWiki.
    @michitux
    michitux committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    b5f4b41 View commit details
    Browse the repository at this point in the history

  2. XCOMMONS-2349: Improve performance of AttributeFilter in HTMLCleaner 

    * Store the XPathFactory in the execution context.
    @michitux
    michitux committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    b913a9b View commit details
    Browse the repository at this point in the history

  3. XCOMMONS-2349: Improve performance of AttributeFilter in HTMLCleaner 

    * Do not protect the call to XPathFactory.newInstance() as it seems thread-safe after all.
    @michitux
    michitux committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    47e0887 View commit details
    Browse the repository at this point in the history

  4. XCOMMONS-2349: Improve performance of AttributeFilter in HTMLCleaner 

    * Replace XPath by simple loop over all elements.
* Make sure that replaced attributes are sorted lexicographically to
  guarantee deterministic results.
    @michitux
    michitux committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    2ff4e3a View commit details
    Browse the repository at this point in the history