From fa70acdb72083179637f7b43153fca79bc9af864 Mon Sep 17 00:00:00 2001 From: xuwei-k <6b656e6a69@gmail.com> Date: Wed, 30 Oct 2024 18:36:22 +0900 Subject: [PATCH 1/8] sbt 1.10.4 --- project/build.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/project/build.properties b/project/build.properties index 0b699c3..09feeee 100644 --- a/project/build.properties +++ b/project/build.properties @@ -1 +1 @@ -sbt.version=1.10.2 +sbt.version=1.10.4 From 1e036447dc6f92d76f42c415c5c55af23c221e59 Mon Sep 17 00:00:00 2001 From: Scala Steward <2517319+scala-steward-bot@users.noreply.github.com> Date: Mon, 30 Sep 2024 04:48:05 +0000 Subject: [PATCH 2/8] Update slick to 3.5.2 (cherry picked from commit aa7891a4f783494ce3854e35aa61767063cab32f) --- build.sbt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.sbt b/build.sbt index 4322820..e6abbf1 100644 --- a/build.sbt +++ b/build.sbt @@ -210,7 +210,7 @@ lazy val inputOutputCommon = Def.settings( Nil } }, - libraryDependencies += "com.typesafe.slick" %% "slick" % "3.5.1", + libraryDependencies += "com.typesafe.slick" %% "slick" % "3.5.2", libraryDependencies += "io.monix" %% "monix-eval" % "3.4.1", libraryDependencies += "org.mockito" % "mockito-subclass" % "5.14.0", libraryDependencies += "org.atnos" %% "eff-core" % "7.0.4" From cbfc924da9ffb61483a1cdb0f1b480f55485bc90 Mon Sep 17 00:00:00 2001 From: xuwei-k <6b656e6a69@gmail.com> Date: Wed, 30 Oct 2024 18:37:53 +0900 Subject: [PATCH 3/8] mockito 5.14.2 --- build.sbt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.sbt b/build.sbt index e6abbf1..7ea2c16 100644 --- a/build.sbt +++ b/build.sbt @@ -212,7 +212,7 @@ lazy val inputOutputCommon = Def.settings( }, libraryDependencies += "com.typesafe.slick" %% "slick" % "3.5.2", libraryDependencies += "io.monix" %% "monix-eval" % "3.4.1", - libraryDependencies += "org.mockito" % "mockito-subclass" % "5.14.0", + libraryDependencies += "org.mockito" % "mockito-subclass" % "5.14.2", libraryDependencies += "org.atnos" %% "eff-core" % "7.0.4" ) From e90d6826426b9593df6dac0028a25e330f260a02 Mon Sep 17 00:00:00 2001 From: Scala Steward <2517319+scala-steward-bot@users.noreply.github.com> Date: Sat, 5 Oct 2024 08:47:19 +0000 Subject: [PATCH 4/8] Update sbt-pgp to 2.3.0 (cherry picked from commit b30d3c897dbcba5f14de5efa986ff1bfc9917565) --- project/plugins.sbt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/project/plugins.sbt b/project/plugins.sbt index 590ef11..b978be7 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -4,7 +4,7 @@ addSbtPlugin("com.eed3si9n" % "sbt-projectmatrix" % "0.10.0") addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.11.3") -addSbtPlugin("com.github.sbt" % "sbt-pgp" % "2.2.1") +addSbtPlugin("com.github.sbt" % "sbt-pgp" % "2.3.0") addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.2") From 93fa995530aecfbcf077220890d9eb3bca9c7749 Mon Sep 17 00:00:00 2001 From: kenji yoshida <6b656e6a69@gmail.com> Date: Wed, 30 Oct 2024 18:45:46 +0900 Subject: [PATCH 5/8] delete output/UnusedConstructorParamsTest.scala --- .../main/scala/fix/UnusedConstructorParamsTest.scala | 10 ---------- 1 file changed, 10 deletions(-) delete mode 100644 output/src/main/scala/fix/UnusedConstructorParamsTest.scala diff --git a/output/src/main/scala/fix/UnusedConstructorParamsTest.scala b/output/src/main/scala/fix/UnusedConstructorParamsTest.scala deleted file mode 100644 index ec6d71d..0000000 --- a/output/src/main/scala/fix/UnusedConstructorParamsTest.scala +++ /dev/null @@ -1,10 +0,0 @@ -package fix - - -class A1(val x: Int) - -class A2(x: Int) - -class A3(`type`: Int) extends A1(`type`) - -class A4(var x: Int) From 6a317ca3da30590adf8d7e56e07ac0010e178f35 Mon Sep 17 00:00:00 2001 From: xuwei-k <6b656e6a69@gmail.com> Date: Wed, 30 Oct 2024 18:57:17 +0900 Subject: [PATCH 6/8] fix UnusedConstructorParams --- .../src/main/scala-3/fix/UnusedConstructorParamsTest2.scala | 6 ++++++ input/src/main/scala/fix/UnusedConstructorParamsTest.scala | 2 ++ rules/src/main/scala/fix/UnusedConstructorParams.scala | 1 + 3 files changed, 9 insertions(+) create mode 100644 input/src/main/scala-3/fix/UnusedConstructorParamsTest2.scala diff --git a/input/src/main/scala-3/fix/UnusedConstructorParamsTest2.scala b/input/src/main/scala-3/fix/UnusedConstructorParamsTest2.scala new file mode 100644 index 0000000..0b9e5b8 --- /dev/null +++ b/input/src/main/scala-3/fix/UnusedConstructorParamsTest2.scala @@ -0,0 +1,6 @@ +/* +rule = UnusedConstructorParams + */ +package fix + +class A6(val x: Int)(using x2: String) diff --git a/input/src/main/scala/fix/UnusedConstructorParamsTest.scala b/input/src/main/scala/fix/UnusedConstructorParamsTest.scala index f0a51cb..96aec0a 100644 --- a/input/src/main/scala/fix/UnusedConstructorParamsTest.scala +++ b/input/src/main/scala/fix/UnusedConstructorParamsTest.scala @@ -10,3 +10,5 @@ class A2(x: Int) // assert: UnusedConstructorParams class A3(`type`: Int) extends A1(`type`) class A4(var x: Int) + +class A5(val x: Int)(implicit x2: String) diff --git a/rules/src/main/scala/fix/UnusedConstructorParams.scala b/rules/src/main/scala/fix/UnusedConstructorParams.scala index edcb83a..2c6ff16 100644 --- a/rules/src/main/scala/fix/UnusedConstructorParams.scala +++ b/rules/src/main/scala/fix/UnusedConstructorParams.scala @@ -21,6 +21,7 @@ class UnusedConstructorParams extends SyntacticRule("UnusedConstructorParams") { case x: Defn.Class if !x.mods.exists(_.is[Mod.Case]) => val params = x.ctor.paramClauses.flatten .filterNot(_.mods.exists(_.is[Mod.Implicit])) + .filterNot(_.mods.exists(_.is[Mod.Using])) .filterNot(_.mods.exists(_.is[Mod.VarParam])) .filterNot(_.mods.exists(_.is[Mod.ValParam])) val allTokens = { From 1a4ca9791575a1e69139100e884f55be49ee322c Mon Sep 17 00:00:00 2001 From: xuwei-k <6b656e6a69@gmail.com> Date: Wed, 30 Oct 2024 19:11:40 +0900 Subject: [PATCH 7/8] sbt-sonatype 3.12.2 --- project/plugins.sbt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/project/plugins.sbt b/project/plugins.sbt index b978be7..18257b7 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -2,7 +2,7 @@ addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.12.1") addSbtPlugin("com.eed3si9n" % "sbt-projectmatrix" % "0.10.0") -addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.11.3") +addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.12.2") addSbtPlugin("com.github.sbt" % "sbt-pgp" % "2.3.0") From 231eedc4c2edd93845b83ccb796227556ed169a5 Mon Sep 17 00:00:00 2001 From: xuwei-k <6b656e6a69@gmail.com> Date: Wed, 30 Oct 2024 19:13:48 +0900 Subject: [PATCH 8/8] Setting version to 0.4.6 --- version.sbt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/version.sbt b/version.sbt index 0231f2e..612370a 100644 --- a/version.sbt +++ b/version.sbt @@ -1 +1 @@ -ThisBuild / version := "0.4.6-SNAPSHOT" +ThisBuild / version := "0.4.6"