Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MD5 checksum for model binary files #8

Open
dustinkerstein opened this issue Nov 29, 2024 · 2 comments
Open

MD5 checksum for model binary files #8

dustinkerstein opened this issue Nov 29, 2024 · 2 comments
Assignees

Comments

@dustinkerstein
Copy link

It would be great to have an automatic checksum verification for the downloaded/cached models. I ran into a small issue with an interrupted download which led to trying to load bad data (and a hard crash). As a rough workaround I am ensuring that the user is allowed to retry the load/download. Maybe before loading the model it could verify the binary MD5?

@xuegao-tzx
Copy link
Owner

Now MD5 verification will be performed after downloading. If you use it in your own project, it is recommended to use a dedicated download dependency and perform MD5 verification after downloading to avoid damage to the model file.

@dustinkerstein
Copy link
Author

Ok great. I'll test that change as soon as I see it added to the main branch. Also, for flexibility, maybe you could add an optional string parameter to the downloader that allows for passing the expected MD5. Would that be feasible? Thanks!

@xuegao-tzx xuegao-tzx self-assigned this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants