Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dump_npz tests #99

Open
JohanMabille opened this issue Oct 19, 2020 · 0 comments
Open

Fix dump_npz tests #99

JohanMabille opened this issue Oct 19, 2020 · 0 comments

Comments

@JohanMabille
Copy link
Member

The current implementation of the tests makes a binary comparison of a file generated with numpy and the file generated with xtensor-io. This comparison can fail wile the files are equivalent, meaning that each of this file can be read by both libraries and will give the same results.

This binary comparison depends on implementation details that do not change the data of the file, so maybe a more reliable test should be considered.

The tests of dump_npz have been commented out to avoid CI failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant