Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xqemu messages consistency #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Xqemu messages consistency #65

wants to merge 1 commit into from

Conversation

Significantbits
Copy link

This pull request aims to close #62. The result of this change can be viewed in the image below.

image

@dracc
Copy link
Contributor

dracc commented Jan 19, 2020 •
edited
Loading

Please consider squishing the commits. Apart from that, your changes look good to me. 👍

@JayFoxRox
Copy link
Member

Please make the commit titles shorter so they don't wrap into the commit description.

I'd like a native speaker do the review.

@Significantbits
Copy link
Author

Okay, I've squashed the commits and made the message shorter. Let me know if there is anything else I need to do.

@GXTX
Copy link
Contributor

GXTX commented Apr 7, 2020

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborgerson mborgerson Awaiting requested review from mborgerson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different names for log area
4 participants
@Significantbits @dracc @JayFoxRox @GXTX